[PATCH] D82989: [flang][NFC] Get formatting in sync with latest clang-format

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 15:41:20 PDT 2020


tskeith added a comment.

In D82989#2126276 <https://reviews.llvm.org/D82989#2126276>, @MyDeveloperDay wrote:

> I'd be interested to know if you felt any of those changes were an unwanted surprise


Most of the differences were in formatting conditional expressions and I thought they were improvements.

My preference would be to have an option not to align things in those expressions. (You'll notice we have turned off all of the alignment options in .clang-format.) For example:

  return IsUpperCaseLetter(ch) ? ch - 'A' + 10
      : IsLowerCaseLetter(ch) ? ch - 'a' + 10
      : DecimalDigitValue(ch);


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82989/new/

https://reviews.llvm.org/D82989





More information about the llvm-commits mailing list