[PATCH] D78851: Debug Info Support for Basic Block Sections

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugHandlerBase.cpp:215-223
+    //
+    // If the first mention of an argument is in a unique-section basic block,
+    // we cannot assign the CurrentFnBegin label, as it lies in a different
+    // section. For simplicity, we simply ignore such mentions in this code.
     const DILocalVariable *DIVar =
         Entries.front().getInstr()->getDebugVariable();
     if (DIVar->isParameter() &&
----------------
tmsriram wrote:
> dblaikie wrote:
> > Is there a test case covering this? Rough sense of how much this hurts debug info quality?
> I am still working on getting a test case for this.  I will iterate on this shortly.
I removed these lines and did a full bootstrap with debuginfo and assertions enabled with basic block sections and see no issues.   These lines were added before we got a lot of debug info right and this seems no longer necessary.   


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78851/new/

https://reviews.llvm.org/D78851