[PATCH] D82717: [InstSimplify] Fold icmp with dominating assume

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 15:09:19 PDT 2020


nikic added a comment.

In D82717#2125651 <https://reviews.llvm.org/D82717#2125651>, @spatel wrote:

> Can we do this in InstSimplify instead? (always folds to constant)


Done! I have some slight compile-time apprehensions about doing this in InstSimplify. On CTMark this is barely above the noise, but that's probably just a result of little assume use in those benchmarks. But I agree that InstSimplify is logically the right place for this, and we can move it, if it becomes a problem.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82717/new/

https://reviews.llvm.org/D82717





More information about the llvm-commits mailing list