[PATCH] D82721: [ScalarEvolution] createSCEV(): recognize `udiv`/`urem` disguised as an `sdiv`/`srem`

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 14:04:29 PDT 2020


nikic added a comment.

Thanks for the context! That makes it clearer what the motivation here is. You are adding a new SCEV-based pass, that runs very early in the pipeline, before even the first InstCombine run, so it needs SCEV to deal with non-canonical IR. I see you mentioned this in the description, but I was missing the "why" of it.

I'm not seeing any negative compile-time impact from this change, so this change seems ok to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82721/new/

https://reviews.llvm.org/D82721





More information about the llvm-commits mailing list