[PATCH] D82988: [RISCV] Avoid Splitting MBB in RISCVExpandPseudo

Luís Marques via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 12:27:09 PDT 2020


luismarques added a comment.

This is looking quite good. As Sam says, not splitting BBs is preferable, so while the D79635 <https://reviews.llvm.org/D79635> issues could be resolved in other ways, if we can make it work like this then that's even better.
I suppose that this patch could also remove everything related to `LabelMustBeEmitted`.
If anyone wants to provide about the status of `setPreInstrSymbol` that would be helpful. Currently it's marked as `FIXME: This is not fully implemented yet.`, although Sam indicates that it's being used by x86, so that may be just a holdover.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82988/new/

https://reviews.llvm.org/D82988





More information about the llvm-commits mailing list