[PATCH] D82892: Added comparision for all types in haveSameSpecialState() of Instruction.cpp

Vishal Chebrolu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 1 08:38:00 PDT 2020


vish99 marked 5 inline comments as done.
vish99 added a comment.

In D82892#2123584 <https://reviews.llvm.org/D82892#2123584>, @nikic wrote:

> At this point, I would recommend writing this as a switch over the instruction opcode.


I do agree that a switch over instruction opcode would make more sense. I updated the revision to do the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82892/new/

https://reviews.llvm.org/D82892





More information about the llvm-commits mailing list