[PATCH] D82774: [Power10] Implement Vector Blend Builtins in LLVM/Clang

[Lei Huang via Phabricator via llvm-commits]

lei added a comment.

p10-permute-ops.ll => builtins-ppc-p10permute.ll



================
Comment at: llvm/include/llvm/IR/IntrinsicsPowerPC.td:1013
+def  int_ppc_vsx_xxblendvb: GCCBuiltin<"__builtin_vsx_xxblendvb">,
+              Intrinsic<[llvm_v16i8_ty],[llvm_v16i8_ty,
+                         llvm_v16i8_ty,llvm_v16i8_ty], [IntrNoMem]>;
----------------
nit: indentation 
This line should match previous.. here it should be under `t` in `int_ppc_...` and following lines addjusted accordingly.
Applies to all 4 defs.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:739
+            (COPY_TO_REGCLASS (XXBLENDVB (COPY_TO_REGCLASS $A, VSRC),
+            (COPY_TO_REGCLASS $B, VSRC), (COPY_TO_REGCLASS $C, VSRC)), VSRC)>;
+  def : Pat<(v8i16 (int_ppc_vsx_xxblendvh v8i16:$A, v8i16:$B, v8i16:$C)),
----------------
nit: indentation


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:742
+            (COPY_TO_REGCLASS (XXBLENDVH (COPY_TO_REGCLASS $A, VSRC),
+            (COPY_TO_REGCLASS $B, VSRC), (COPY_TO_REGCLASS $C, VSRC)), VSRC)>;
+  def : Pat<(int_ppc_vsx_xxblendvw v4i32:$A, v4i32:$B, v4i32:$C),
----------------
nit: indentation


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82774/new/

https://reviews.llvm.org/D82774