[PATCH] D82440: [Power10] Implement Vector Shift Double Bit Immediate Builtins in LLVM/Clang

[Lei Huang via Phabricator via llvm-commits]

lei requested changes to this revision.
lei added a comment.
This revision now requires changes to proceed.

Please use similar naming for all new builtin test files:
p10-permute-ops.ll => builtins-ppc-p10permute.ll



================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:742
+                                [(set v16i8:$VRT,
+                                (int_ppc_altivec_vsldbi v16i8:$VRA, v16i8:$VRB,
+                                i32:$SH))]>;
----------------
nit: indent to align to `(` in the previous line.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:743
+                                (int_ppc_altivec_vsldbi v16i8:$VRA, v16i8:$VRB,
+                                i32:$SH))]>;
   def VSRDBI : VNForm_VTAB5_SD3<22, 1, (outs vrrc:$VRT),
----------------
nit: this should align with `int_ppc...` in previous line.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:749
+                                [(set v16i8:$VRT,
+                                (int_ppc_altivec_vsrdbi v16i8:$VRA, v16i8:$VRB, 
+                                i32:$SH))]>;
----------------
same.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:750
+                                (int_ppc_altivec_vsrdbi v16i8:$VRA, v16i8:$VRB, 
+                                i32:$SH))]>;
    def VPDEPD : VXForm_1<1485, (outs vrrc:$vD), (ins vrrc:$vA, vrrc:$vB),
----------------
same.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82440/new/

https://reviews.llvm.org/D82440