[PATCH] D82780: [AArch64][SVE] Put zeroing pseudos and patterns under flag.

[Paul Walker via Phabricator via llvm-commits]

paulwalker-arm added inline comments.


================
Comment at: llvm/lib/Target/AArch64/SVEInstrFormats.td:1576
   def _H : sve_fp_2op_p_zds<0b01, opc, asm, ZPR16>,
-           SVEPseudo2Instr<Ps # _H, 1>, SVEInstr2Rev<NAME # _H, revname # _H, isOrig>;
+           SVEPseudo2Instr<Ps # _H, 1>, SVEInstr2Rev<NAME # _H, revname # _H, isReverseInstr>;
   def _S : sve_fp_2op_p_zds<0b10, opc, asm, ZPR32>,
----------------
I think you need to either invert isReverseInstr before passing to SVEInstr2Rev or update SVEInstr2Rev.

Perhaps it's worth deferring the isReverseInstr part of this change?  It's up to you but you could just change the default value of isOrig to 1 if it's the "not having to do anything special for non-reversed instructions" part you're most interested in.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82780/new/

https://reviews.llvm.org/D82780