[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

Wed Jul 1 05:54:49 PDT 2020

lei added inline comments.

================
Comment at: clang/test/CodeGen/builtins-ppc-p10vector.c:108
+                           signed char *__c) {
+  // CHECK-BE: store i8 %{{.+}}, i8* %{{.+}}, align 1
+  // CHECK-LE: store i8 %{{.+}}, i8* %{{.+}}, align 1
----------------
amyk wrote:
> lei wrote:
> > I don't see a run line above that uses `CHECK-BE|CHECK-LE`.  Since all these look the same, did you mean to use the default `CHECK`?
> You're right - unfortunately in the previous tests that use `CHECK-BE`/`CHECK-LE` that were committed, I did not realize that I forgot to upstream the appropriate RUN lines... If it is okay, I can add them into this patch when I update it. 
Not sure what you mean by appropriate RUN lines.  From the checks you are adding seems there is no diff between BE and LE so both can use the default `CHECK`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82467/new/

https://reviews.llvm.org/D82467