[PATCH] D82877: [llvm-readobj] - Don't crash when checking the number of dynamic symbols.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Couple of nits, otherwise LGTM.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols-size-from-hash-table.test:163
+
+## Show we report a warning when the sh_entsize of the SHT_DYNSYM section is null and therefore we are unable
+## to derive the number of dynamic symbols from SHT_DYNSYM section header.
----------------
null -> zero

Also below in file names.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dyn-symbols-size-from-hash-table.test:251
     AddressAlign: 0x400
+## 0x18 is no-op.
+    EntSize:      [[ENTSIZE=0x18]]
----------------
I'd change "is no-op" to "is the standard entsize value"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82877/new/

https://reviews.llvm.org/D82877