[PATCH] D82923: introducing llvm-libtool

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

1. Has the introduction of a new tool been discussed on llvm-dev? (I vaguely recall that it might have been but might be getting confused). Please include a link to the mailing thread in the description.

2. Is this significantly different to llvm-ar and its aliases? If so, please outline the differences.

3. Assuming this is going to be developed, could you split off one or two patches that make this even simpler, please. For example, the very first patch would just add the tool with only the built-in --help/--version options, not doing anything useful.

4. You may want to consider using `cl::opt` instead of the tablegen approach you're currently using, since it's simpler and I doubt you need complex logic here.

5. There are some basic error handling functions available in the Support library which might do all you need them to. Consider using them before rolling your own.

5. Is there going to be non-Darwin versions of this tool? If not, it doesn't need to be located in the Darwin sub-directory.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82923/new/

https://reviews.llvm.org/D82923