[PATCH] D82828: [ELF] Don't resolve a relocation in .debug_line referencing an ICF folded symbol to the tombstone value

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

Two nits, otherwise LGTM, but might be worth getting others to confirm they're happy with the behaviour too.



================
Comment at: lld/ELF/InputSection.cpp:932
+      // .debug_line to -1 would stop debugger users from setting breakpoints on
+      // the folded-in function, So exclude .debug_line.
       //
----------------
Nit: So -> so


================
Comment at: lld/test/ELF/debug-dead-reloc-icf.s:32
+## prevent users from setting breakpoints on the folded-in functions.
+## Instead resolve the relocation to the folded .text.1 to .text
+.section .debug_line
----------------
Nit: missing trailing full stop.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82828/new/

https://reviews.llvm.org/D82828