[PATCH] D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions.

Tue Jun 30 20:35:44 PDT 2020

lei added inline comments.

================
Comment at: llvm/test/CodeGen/PowerPC/power10-immediate-moves-and-splats.ll:11
+; RUN:     -ppc-asm-full-reg-names -mcpu=pwr10 < %s | FileCheck %s \
+; RUN:     --check-prefix=CHECK-P10-BE
+
----------------
lei wrote:
> Was thinking maybe we can break this test file into 2 different ones:
> 1. `p10-splatsImm.ll` 
>   * contain tests that produces the same code for both LE/BE (not dependent of PCRel).
>   * both run lines can use default for check prefix.
> 2. `p10-splatsImm-pcrel.ll`
>   * contain tests that produce code dependent on whether PCRel is supported or not
>   * Use default for PCRel enabled (LE tests) and CHECK-TOC for when it's not (ie BE and when PCRel is disabled).
I meant `p10-splatImm.ll` and `p10-splatImm-no-pcrel.ll`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82911/new/

https://reviews.llvm.org/D82911