[PATCH] D82705: [X86-64] Support Intel AMX instructions

Xiang Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 30 17:56:01 PDT 2020


xiangzhangllvm added a comment.

In D82705#2124135 <https://reviews.llvm.org/D82705#2124135>, @craig.topper wrote:

> -Fix the previously noted missing break
>  -Prevent trying to create a register encoding past tmm7


OK



================
Comment at: llvm/utils/TableGen/X86RecognizableInstr.cpp:804
   case X86Local::MRM6X: case X86Local::MRM7X:
     filter = std::make_unique<ExtendedFilter>(true, Form - X86Local::MRM0X);
+  case X86Local::MRMr0:
----------------
pengfei wrote:
> You missed break here. That's the reason it failed.
Thank you very much!!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82705/new/

https://reviews.llvm.org/D82705





More information about the llvm-commits mailing list