[PATCH] D82911: [PowerPC][Power10] Exploit the xxspltiw and xxspltidp instructions.

Tue Jun 30 16:50:50 PDT 2020

amyk marked 2 inline comments as done.
amyk added inline comments.

================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:708
+                                      [(set v2f64:$XT,
+				             (PPCxxspltidp i32:$IMM32))]>;
   def XXSPLTI32DX :
----------------
lei wrote:
> nit: indentation is off.
I'm not entirely sure why the indentation appears like that, as the indentation is correct in the patch... (under `v2f64`).

================
Comment at: llvm/test/CodeGen/PowerPC/power10-immediate-moves-and-splats.ll:4
+; RUN:     -ppc-asm-full-reg-names -mcpu=pwr10 < %s | FileCheck %s \
+; RUN:     --check-prefix=CHECK-P10
+
----------------
lei wrote:
> Do we need BE run line here?
I've added the BE line for now as different code is generated for tests similar to `testDoubleToDoubleFail`. If there is a preference to remove the BE line, I can remove it. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82911/new/

https://reviews.llvm.org/D82911