[PATCH] D82430: [SVE] Reject vector struct indexes for scalable vector GEPs

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 30 14:09:47 PDT 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rGdf1f371e2830: [SVE] Reject vector struct indexes for scalable vectors. (authored by efriedma).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82430/new/

https://reviews.llvm.org/D82430

Files:
  llvm/lib/IR/Type.cpp
  llvm/test/Assembler/getelementptr_vscale_struct.ll


Index: llvm/test/Assembler/getelementptr_vscale_struct.ll
===================================================================
--- /dev/null
+++ llvm/test/Assembler/getelementptr_vscale_struct.ll
@@ -0,0 +1,10 @@
+; RUN: not llvm-as < %s >/dev/null 2> %t
+; RUN: FileCheck %s < %t
+; Test that a scalable vector struct index is rejected.
+
+; CHECK: invalid getelementptr indices
+
+define <vscale x 2 x i32*> @test7(<vscale x 2 x {i32, i32}*> %a) {
+  %w = getelementptr {i32, i32}, <vscale x 2 x {i32, i32}*> %a, <vscale x 2 x i32> zeroinitializer, <vscale x 2 x i32> zeroinitializer
+  ret <vscale x 2 x i32*> %w
+}
Index: llvm/lib/IR/Type.cpp
===================================================================
--- llvm/lib/IR/Type.cpp
+++ llvm/lib/IR/Type.cpp
@@ -548,6 +548,8 @@
   // vector case all of the indices must be equal.
   if (!V->getType()->isIntOrIntVectorTy(32))
     return false;
+  if (isa<ScalableVectorType>(V->getType()))
+    return false;
   const Constant *C = dyn_cast<Constant>(V);
   if (C && V->getType()->isVectorTy())
     C = C->getSplatValue();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82430.274610.patch
Type: text/x-patch
Size: 1081 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200630/a2c612f2/attachment.bin>


More information about the llvm-commits mailing list