[PATCH] D82896: [PowerPC][Power10] Add Vector Splat Immediate, Permute, Blend, Shift Double Bit immediate Instruction Definitions and MC Tests

[Amy Kwan via Phabricator via llvm-commits]

amyk marked an inline comment as done.
amyk added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:331
+
+class 8RR_XX4_XTABC6<bits<6> opcode, bits<2> xo, dag OOL, dag IOL,
+                     string asmstr, InstrItinClass itin, list<dag> pattern>
----------------
lei wrote:
> nit... wondering if we can reorder this 2 class def so its:
> 
> ```
> class 8RR_XX4_XTABC6
> ....
> class 8RR_XX4_IMM3_XTABC6
> ...
> ```
> Seems like the class defined on line 180 `class 8RR_XX4Form_IMM8_XTAB6` should of been named `class 8RR_XX4Form_IMM8_XTABC6`?
> 
> If so it would be good if these are defined in order.
> What's the diff in `XX4` vs `XX4Form` in the naming?
Sure, I can reorder it so the `IMM` version comes after.
I believe `XX4` and `XX4Form` is referring to the same form. I think it's likely we forgot to put `Form`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82896/new/

https://reviews.llvm.org/D82896