[PATCH] D82602: [SelectionDAG] don't split branch on logic-of-vector-compares

[Ulrich Weigand via Phabricator via llvm-commits]

uweigand added a comment.

I've now updated the knownbits.ll test case to make it less fragile and still test what it is supposed to test (commit e9c6b63 <https://reviews.llvm.org/rGe9c6b63d4a16c7955bf0e7d5c1ab4adbb9d385cc>).   The problem was use of "undef" (which makes it susceptible to collapse as generic optimizations improve), and the fact that knownBits was operating at the very edge of MaxRecursionDepth, so changes in common code could push it above the limit.

Can you retry with current mainline?  Hopefully, the test case now no longer changes with your patch.

As to shouldScalarizeBinop, thanks for pointing this out!   I agree we probably ought to define this, but I think I'd like to evaluate the changes this is causing to real-world code before checking it in.  @jonpa, can you have a look?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82602/new/

https://reviews.llvm.org/D82602