[llvm] e9c6b63 - [SystemZ] Simplify knownbits.ll test

[Ulrich Weigand via llvm-commits]

Author: Ulrich Weigand
Date: 2020-06-30T16:31:59+02:00
New Revision: e9c6b63d4a16c7955bf0e7d5c1ab4adbb9d385cc

URL: https://github.com/llvm/llvm-project/commit/e9c6b63d4a16c7955bf0e7d5c1ab4adbb9d385cc
DIFF: https://github.com/llvm/llvm-project/commit/e9c6b63d4a16c7955bf0e7d5c1ab4adbb9d385cc.diff

LOG: [SystemZ] Simplify knownbits.ll test

The knownbits.ll test case is somewhat fragile since:
- it relies on undef inputs; and
- it operates just at the limits of the MaxRecursionDepth

This means that optimization changes may easily cause the test
to spuriously fail.  Rewrite the test so it still validates
the same thing, but in a less fragile manner.

Added: 
    

Modified: 
    llvm/test/CodeGen/SystemZ/knownbits.ll

Removed: 
    


################################################################################
diff  --git a/llvm/test/CodeGen/SystemZ/knownbits.ll b/llvm/test/CodeGen/SystemZ/knownbits.ll
index 08694d8e6997..9c40b307cf16 100644
--- a/llvm/test/CodeGen/SystemZ/knownbits.ll
+++ b/llvm/test/CodeGen/SystemZ/knownbits.ll
@@ -4,18 +4,22 @@
 ; Test that DAGCombiner gets helped by computeKnownBitsForTargetNode().
 
 ; SystemZISD::REPLICATE
-define i32 @f0(<4 x i32> %a0) {
+define i32 @f0(<4 x i32> *%p0) {
 ; CHECK-LABEL: f0:
 ; CHECK:       # %bb.0:
-; CHECK-NEXT:    vgbm %v0, 0
-; CHECK-NEXT:    vceqf %v0, %v24, %v0
+; CHECK-NEXT:    vl %v0, 0(%r2), 3
+; CHECK-NEXT:    vgbm %v1, 0
+; CHECK-NEXT:    vceqf %v0, %v0, %v1
 ; CHECK-NEXT:    vrepif %v1, 1
 ; CHECK-NEXT:    vnc %v0, %v1, %v0
+; CHECK-NEXT:    vst %v0, 0(%r2), 3
 ; CHECK-NEXT:    vlgvf %r2, %v0, 3
 ; CHECK-NEXT:    # kill: def $r2l killed $r2l killed $r2d
 ; CHECK-NEXT:    br %r14
+  %a0 = load <4 x i32>, <4 x i32>* %p0, align 8
   %cmp0 = icmp ne <4 x i32> %a0, zeroinitializer
   %zxt0 = zext <4 x i1> %cmp0 to <4 x i32>
+  store <4 x i32> %zxt0, <4 x i32>* %p0, align 8
   %ext0 = extractelement <4 x i32> %zxt0, i32 3
   br label %exit
 
@@ -31,36 +35,40 @@ exit:
 ; The DAG XOR has JOIN_DWORDS and REPLICATE operands. With KnownBits properly set
 ; for both these nodes, ICMP is used instead of TM during lowering because
 ; adjustForRedundantAnd() succeeds.
-define void @f1() {
+define void @f1(i64 %a0, i64 %a1) {
 ; CHECK-LABEL: f1:
 ; CHECK:       # %bb.0:
-; CHECK-NEXT:    clhhsi 0, 0
-; CHECK-NEXT:    lhi %r0, 0
-; CHECK-NEXT:    lochie %r0, 1
-; CHECK-NEXT:    lghi %r1, 1
+; CHECK-NEXT:    risbgn %r0, %r2, 63, 191, 0
+; CHECK-NEXT:    risbgn %r1, %r3, 63, 191, 0
 ; CHECK-NEXT:    vlvgp %v0, %r0, %r1
 ; CHECK-NEXT:    vrepig %v1, 1
 ; CHECK-NEXT:    vx %v0, %v0, %v1
-; CHECK-NEXT:    vlgvf %r0, %v0, 1
-; CHECK-NEXT:    cijlh %r0, 0, .LBB1_3
+; CHECK-NEXT:    vlgvg %r0, %v0, 0
+; CHECK-NEXT:    cgijlh %r0, 0, .LBB1_3
 ; CHECK-NEXT:  # %bb.1:
-; CHECK-NEXT:    vlgvf %r0, %v0, 3
-; CHECK-NEXT:    cijlh %r0, 0, .LBB1_3
+; CHECK-NEXT:    vlgvg %r0, %v0, 1
+; CHECK-NEXT:    cgijlh %r0, 0, .LBB1_3
 ; CHECK-NEXT:  # %bb.2:
 ; CHECK-NEXT:  .LBB1_3:
-  %1 = load i16, i16* null, align 2
-  %2 = icmp eq i16 %1, 0
-  %3 = insertelement <2 x i1> undef, i1 %2, i32 0
-  %4 = insertelement <2 x i1> %3, i1 true, i32 1
-  %5 = xor <2 x i1> %4, <i1 true, i1 true>
-  %6 = extractelement <2 x i1> %5, i32 0
-  %7 = extractelement <2 x i1> %5, i32 1
-  %8 = or i1 %6, %7
-  br i1 %8, label %10, label %9
+  %1 = and i64 %a0, 1
+  %2 = and i64 %a1, 1
+  %3 = insertelement <2 x i64> undef, i64 %1, i32 0
+  %4 = insertelement <2 x i64> %3, i64 %2, i32 1
+  %5 = xor <2 x i64> %4, <i64 1, i64 1>
+  %6 = extractelement <2 x i64> %5, i32 0
+  %7 = and i64 %6, 1
+  %8 = icmp eq i64 %7, 0
+  br i1 %8, label %9, label %14
 
-; <label>:8:                                      ; preds = %0
+; <label>:9:                                      ; preds = %0
+  %10 = extractelement <2 x i64> %5, i32 1
+  %11 = and i64 %10, 1
+  %12 = icmp eq i64 %11, 0
+  br i1 %12, label %13, label %14
+
+; <label>:13:                                      ; preds = %0
   unreachable
 
-; <label>:9:                                      ; preds = %0
+; <label>:14:                                      ; preds = %0
   unreachable
 }