[PATCH] D82861: [Attributor] Add AAValueSimplifyCallSiteArgument::manifest

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 30 05:55:43 PDT 2020


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM. One nit



================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:4686
+    Use &U = cast<CallBase>(&getAnchorValue())->getArgOperandUse(getArgNo());
+    if (C) {
+      // We can replace the AssociatedValue with the constant.
----------------
Move the U into the conditional or make `if (!C) return` an early exit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82861/new/

https://reviews.llvm.org/D82861





More information about the llvm-commits mailing list