[PATCH] D82860: Port ObjCMTAction to new option parsing system

[Daniel Grumberg via Phabricator via llvm-commits]

dang created this revision.
dang added a reviewer: Bigcheese.
Herald added subscribers: llvm-commits, cfe-commits, jfb, dexonsmith.
Herald added projects: clang, LLVM.
dang marked an inline comment as done.
dang added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:328-331
+  HelpText<"Enable migration to modern ObjC literals">,
+  MarshallingInfoFlag<"FrontendOpts.ObjCMTAction", "0", "unsigned">, Normalizer<"normalizeFlagToValue<unsigned>">,
+  ValueMerger<"MERGE_VALUE_MASK">, ValueExtractor<"EXTRACT_VALUE_MASK">,
+  NormalizerCookie<"FrontendOptions::ObjCMT_Literals">;
----------------
If this kind of combination of normalizer, value merger and extractor happen again, I will make a mixin that helps set this up. Or do you reckon it is worth doing it now for readability.


Merge existing marhsalling info kinds and add some primitives to
express flag options that contribute to a bitfield.

Depends on D82574 <https://reviews.llvm.org/D82574>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D82860

Files:
  clang/include/clang/Driver/Options.td
  clang/lib/Frontend/CompilerInvocation.cpp
  llvm/include/llvm/Option/OptParser.td
  llvm/utils/TableGen/OptParserEmitter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D82860.274410.patch
Type: text/x-patch
Size: 30789 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200630/4b9dbd44/attachment.bin>