[PATCH] D82827: [DebugInfo] Fix LineTest byteswap for cross-targeting builds

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 30 01:02:45 PDT 2020


jhenderson added a comment.

In D82827#2121798 <https://reviews.llvm.org/D82827#2121798>, @ikudrin wrote:

> The patch looks appropriate, but now I think that maybe it would have been enough to simply use symmetrical constants for these particular tests?


Testing endianness behaviour of the code under test is not what the original change was about, so getting rid of this byte-swapping code entirely would make the testing simpler, I agree. @daltenty, are you happy to do that? It should be a fairly straightforward change, I believe.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82827/new/

https://reviews.llvm.org/D82827





More information about the llvm-commits mailing list