[PATCH] D82708: [MachineLICM] NFC - make safety of moving explicitly for IsLoopInvariantInst

[ChenZheng via Phabricator via llvm-commits]

shchenz marked an inline comment as done.
shchenz added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineLICM.cpp:219
 
-    bool IsLoopInvariantInst(MachineInstr &I);
+    bool IsLoopInvariantInst(MachineInstr &I, bool &IsSafeToMove);
 
----------------
efriedma wrote:
> Instead of returning the IsSafeToMove bit, maybe it would be simpler to add an input parameter "AllowRematOperands"?
Make sense. Will do this after its child patch D82709's solution is determined.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82708/new/

https://reviews.llvm.org/D82708