[PATCH] D82775: [AArch64][SVE] Remove local_unnamed_addr from tuple create tests

Francesco Petrogalli via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 29 09:42:34 PDT 2020


fpetrogalli added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-create-tuple.ll:747-749
 attributes #0 = { nounwind "target-features"="+sve" }
 ; +bf16 is required for the bfloat version.
 attributes #1 = { nounwind "target-features"="+sve,+bf16" }
----------------
given that we are doing a clean up, I'd suggest also removing attribute #0, as +sve is specified at command line, and use an attribute only for the bfloat test cases.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82775/new/

https://reviews.llvm.org/D82775





More information about the llvm-commits mailing list