[PATCH] D82658: [FileCheck][NFC] Clean up RUN style in verbose.txt test

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 29 08:36:45 PDT 2020


jdenny marked an inline comment as done.
jdenny added inline comments.


================
Comment at: llvm/test/FileCheck/verbose.txt:2-3
+; RUN: %ProtectFileCheckOutput \
+; RUN: FileCheck -dump-input=never -input-file %s %s 2>&1 | \
+; RUN:   FileCheck -check-prefix QUIET --allow-empty %s
+
----------------
jhenderson wrote:
> jdenny wrote:
> > jhenderson wrote:
> > > Can I make one minor suggestion whilst you're changing these lines: Change the single-dash arguments for double-dash (or vice versa, but I prefer the first). The reason is that there's an inconsistency in the number of dashes for different options, and it would be nice if it were consistent. It's not a big deal at all of course!
> > Sure, but how do you prefer to write `-vv`?
> Hmmm... good question! I'd probably do single dash, but don't mind either way.
OK, I'll go with `--` for everything here but `-v` and `-vv`.  Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82658/new/

https://reviews.llvm.org/D82658





More information about the llvm-commits mailing list