[PATCH] D82564: [SVE][CodeGen] Fix bug in DAGCombiner::reduceBuildVecToShuffle

Cullen Rhodes via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 29 06:26:38 PDT 2020


c-rhodes accepted this revision.
c-rhodes added a comment.
This revision is now accepted and ready to land.

@david-arm LGTM, just a couple of nits in the test that could be fixed



================
Comment at: llvm/test/CodeGen/AArch64/sve-merging-stores.ll:3
+
+%"complex" = type { { double, double } }
+
----------------
can this not be `%complex`?


================
Comment at: llvm/test/CodeGen/AArch64/sve-merging-stores.ll:14
+
+define void @foo1(%"complex"* %outval,<vscale x 2 x i1> %pred, double *%inptr) {
+; CHECK-LABEL: foo1:
----------------
nit: space after first arg


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82564/new/

https://reviews.llvm.org/D82564





More information about the llvm-commits mailing list