[PATCH] D82405: [openmp] Move Directive and Clause helper function to tablegen

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 29 06:26:37 PDT 2020


jdenny added a comment.

In D82405#2118242 <https://reviews.llvm.org/D82405#2118242>, @clementval wrote:

> About the file splitting I would be in favor to split in at least two files but with no string opinion as said before. What about you @jdenny, @jdoerfert?


So far, it seems that the three of us slightly prefer splitting, and it seems there's some precedent for this in mlir.  If @thakis or others do not object today, then maybe just go with what you think is right.  It can always be changed later.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82405/new/

https://reviews.llvm.org/D82405





More information about the llvm-commits mailing list