[PATCH] D82474: [VectorCombine] try to form vector compare and binop to eliminate scalar ops

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VectorCombine.cpp:89
+/// Determine which, if any, of the inputs should be replaced by a shuffle.
+ExtractElementInst *VectorCombine::getShuffleExtract(
+    ExtractElementInst *Ext0, ExtractElementInst *Ext1,
----------------
RKSimon wrote:
> Maybe pull this out as a precommit NFC?
Yes, I'll do that. I did not do it in advance of this review because it introduces some redundancy for the existing code. So it is of questionable value without the new caller.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82474/new/

https://reviews.llvm.org/D82474