[PATCH] D77443: [RISCV] Fix RISCVInstrInfo::getInstSizeInBytes for atomics pseudos

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

In D77443#2118980 <https://reviews.llvm.org/D77443#2118980>, @lewis-revill wrote:

> Bumping this patch - Looking at the output of the riscv-expand-pseudos pass I'd say these values are accurate. I'd say comments here, and in the functions which expand the instructions to ensure things don't get changed - seems to me like tests would be a little tricky so perhaps omitting that would be fine just to get this landed.


Ugh yes I never followed up on this properly. I started trying to write test but it seemed really fragile; the tests could maybe enforce they were _approximately_ correct but at the IR level there's just not enough control to know exactly how many bytes you're trying to create a branch for. Maybe MIR tests would work. If someone wants to pick this up and add tests by all means please do, but I don't have the time available to do that myself unfortunately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77443/new/

https://reviews.llvm.org/D77443