[llvm] 28ef93c - Revert "Disable a JSONTest.Integers test with all MSVCs, PR46470"

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 19:30:54 PDT 2020


Author: Nico Weber
Date: 2020-06-26T22:30:24-04:00
New Revision: 28ef93cb144235a174db525605f52778d2a97cb6

URL: https://github.com/llvm/llvm-project/commit/28ef93cb144235a174db525605f52778d2a97cb6
DIFF: https://github.com/llvm/llvm-project/commit/28ef93cb144235a174db525605f52778d2a97cb6.diff

LOG: Revert "Disable a JSONTest.Integers test with all MSVCs, PR46470"

This reverts commit 63bcf89125fdfe8a41b0125454b006b49abb0184.
Turns out the more targeted disablement in the previous change
was good enough.

Added: 
    

Modified: 
    llvm/unittests/Support/JSONTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/Support/JSONTest.cpp b/llvm/unittests/Support/JSONTest.cpp
index e150fffbfa83..73fc626af8cb 100644
--- a/llvm/unittests/Support/JSONTest.cpp
+++ b/llvm/unittests/Support/JSONTest.cpp
@@ -326,7 +326,7 @@ TEST(JSONTest, Integers) {
 
       // PR46470,
       // https://developercommunity.visualstudio.com/content/problem/1093399/incorrect-result-when-printing-6917529027641081856.html
-#if !defined(_MSC_VER)
+#if !defined(_MSC_VER) || _MSC_VER < 1926
       {
           "Dynamically exact integer. Stored as double, convertible.",
           double{0x6000000000000000},


        


More information about the llvm-commits mailing list