[PATCH] D81827: [CGP] Convert phi types

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

InstCombine has a transform that, as far as I can see, does essentially the same as this in https://github.com/llvm/llvm-project/blob/903cf140d0118cf0d3f0f6f8967c6a20d9c5be6b/llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp#L2298. I'm wondering why it is necessary to duplicate the logic in CGP. Is this because other CGP transformations only enable the transform to apply?

The InstCombine transform also had a series of issues (multiple instances of infinite loops and unprofitable transforms), so D82676 <https://reviews.llvm.org/D82676> looks familiar :) Comparing some of the logic, I'm also wondering whether this transform is legal for volatile stores (InstCombine guards by isSimple).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81827/new/

https://reviews.llvm.org/D81827