[PATCH] D81682: [PGO] Extend the value profile buckets for mem op sizes.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 13:08:44 PDT 2020


yamauchi updated this revision to Diff 273820.
yamauchi added a comment.

Further refined the MSVC related code.

Based on https://godbolt.org/z/BxlSWX,

- __popcnt and __popcnt64 aren't available on arm/arm64 and not on all x86/x86-64 CPUs. So, go back to bit twiddling.
- _BitScanReverse64 is available on arm64 and x86-64 only.
- Removed static_cast as this is included in a .c file.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81682/new/

https://reviews.llvm.org/D81682

Files:
  compiler-rt/include/profile/InstrProfData.inc
  compiler-rt/lib/profile/InstrProfilingValue.c
  llvm/include/llvm/ProfileData/InstrProf.h
  llvm/include/llvm/ProfileData/InstrProfData.inc
  llvm/include/llvm/Transforms/Instrumentation/InstrProfiling.h
  llvm/lib/ProfileData/InstrProf.cpp
  llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp
  llvm/lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp
  llvm/test/Transforms/PGOProfile/memcpy.ll
  llvm/test/Transforms/PGOProfile/memop_profile_funclet.ll
  llvm/unittests/ProfileData/CMakeLists.txt
  llvm/unittests/ProfileData/InstrProfDataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D81682.273820.patch
Type: text/x-patch
Size: 28857 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200626/da1597e1/attachment-0001.bin>


More information about the llvm-commits mailing list