[PATCH] D82652: AMDGPU/GlobalISel: Select icmp intrinsic

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 07:03:22 PDT 2020


arsenm added a comment.

If you're running into these, you should probably switch to using the new ballot intrinsics. I wasn't planning on working on this and fcmp since they're deprecated



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp:1019-1020
+
+  assert(MRI->getType(Dst).getSizeInBits() == STI.getWavefrontSize() &&
+         "Result size should match WavefrontSize");
+
----------------
Should fail to select rather than assert


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82652/new/

https://reviews.llvm.org/D82652





More information about the llvm-commits mailing list