[PATCH] D82601: [FileCheck] Permit multiple -v or -vv

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 26 00:31:45 PDT 2020


jhenderson added a comment.

Tentative LGTM, but I'd like to see the test tidy-up separated out before formally approving.



================
Comment at: llvm/test/FileCheck/verbose.txt:2
+; RUN: %ProtectFileCheckOutput \
+; RUN: FileCheck -dump-input=never -input-file %s %s 2>&1 \
 ; RUN: | FileCheck -check-prefix QUIET --allow-empty %s
----------------
More than happy for you to make these tidy ups, but can you do them in a separate change, please? It makes it a little trickier to identify which cases existed before, versus which ones are new.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82601/new/

https://reviews.llvm.org/D82601





More information about the llvm-commits mailing list