[PATCH] D77152: [SelectionDAG] Better legalization for FSHL and FSHR

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 25 04:17:03 PDT 2020


foad marked an inline comment as done.
foad added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6289
-        return;
-      }
-
----------------
RKSimon wrote:
> @foad We've lost this functionality - this needs adding to the new expansion code or to DAGCombiner
` TargetLowering::expandROT` does this: "// If a rotate in the other direction is supported, use it." Are there tests showing that it's not working for some reason?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77152/new/

https://reviews.llvm.org/D77152





More information about the llvm-commits mailing list