[llvm] fd9f5f9 - [llvm] Remove full stop frome error message

Jonas Devlieghere via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 09:41:24 PDT 2020


Author: Jonas Devlieghere
Date: 2020-06-24T09:41:17-07:00
New Revision: fd9f5f9c1b75d6d5a6d0f12d189ea87ae82c94a0

URL: https://github.com/llvm/llvm-project/commit/fd9f5f9c1b75d6d5a6d0f12d189ea87ae82c94a0
DIFF: https://github.com/llvm/llvm-project/commit/fd9f5f9c1b75d6d5a6d0f12d189ea87ae82c94a0.diff

LOG: [llvm] Remove full stop frome error message

Address post-commit feedback from James Henderson in D80959.

Added: 
    

Modified: 
    llvm/test/tools/llvm-dwarfdump/cmdline.test
    llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/test/tools/llvm-dwarfdump/cmdline.test b/llvm/test/tools/llvm-dwarfdump/cmdline.test
index 9bf796ffa40b..5c7b998338c7 100644
--- a/llvm/test/tools/llvm-dwarfdump/cmdline.test
+++ b/llvm/test/tools/llvm-dwarfdump/cmdline.test
@@ -35,4 +35,4 @@ RUN: llvm-dwarfdump -
diff  -verbose 2>&1 | FileCheck --check-prefix=INCOMPATIBLE
 INCOMPATIBLE: error: incompatible arguments: specifying both -
diff  and -verbose is currently not supported
 
 RUN: not llvm-dwarfdump --debug-names=0x0 2>&1 | FileCheck --check-prefix=FLAG %s
-FLAG: for the --debug-names option: this is a flag and does not take a value.
+FLAG: for the --debug-names option: this is a flag and does not take a value

diff  --git a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
index 47e426b2561b..d8fa4f9953dc 100644
--- a/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ b/llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -63,7 +63,7 @@ class parser<OffsetOption> final : public basic_parser<OffsetOption> {
       return false;
     }
     if (Arg.getAsInteger(0, Val.Val))
-      return O.error("'" + Arg + "' value invalid for integer argument!");
+      return O.error("'" + Arg + "' value invalid for integer argument");
     Val.HasValue = true;
     Val.IsRequested = true;
     return false;
@@ -89,7 +89,7 @@ template <> class parser<BoolOption> final : public basic_parser<BoolOption> {
   /// Return true on error.
   bool parse(Option &O, StringRef ArgName, StringRef Arg, BoolOption &Val) {
     if (Arg != "")
-      return O.error("this is a flag and does not take a value.");
+      return O.error("this is a flag and does not take a value");
     Val.Val = 0;
     Val.HasValue = false;
     Val.IsRequested = true;


        


More information about the llvm-commits mailing list