[PATCH] D82366: [yaml2obj] - Support reading a content as an array of bytes using the new 'ContentArray' key.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 24 02:07:52 PDT 2020


grimar marked an inline comment as done.
grimar added inline comments.


================
Comment at: llvm/include/llvm/ObjectYAML/ELFYAML.h:256-257
+
+  // Is used when a content is read as an array of bytes.
+  Optional<std::vector<uint8_t>> ContentBuf;
 };
----------------
jhenderson wrote:
> It probably makes sense to place this and `Content` next to each other, since they are logically related.
I've put it here, because `ContentBuf` is not a key, while `Content`, `Size` and `Info` are.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82366/new/

https://reviews.llvm.org/D82366





More information about the llvm-commits mailing list