[PATCH] D81695: [flang] Turn off FLANG_ENABLE_WERROR by default

Tim Keith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 23 07:26:11 PDT 2020


tskeith added a comment.

In D81695#2108974 <https://reviews.llvm.org/D81695#2108974>, @DavidTruby wrote:

> There is another example here of our BuildBots failing for very spurious warnings due to -Werror:
>  http://lab.llvm.org:8014/builders/flang-aarch64-ubuntu-clang/builds/229/steps/build-unified-tree/logs/stdio


The warning is not spurious, so this example shows `-Werror` in the best possible light:
On the positive side, it detected a real error that was immediately fixed and might not have been noticed so soon if it were just a warning.
On the negative side, it prevented the rest of the build from happening and tests from being run, as happens with any compilation error.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81695/new/

https://reviews.llvm.org/D81695





More information about the llvm-commits mailing list