[PATCH] D81270: [XCOFF][AIX] Use 'L..' instead of '.L' for getPrivateGlobalPrefix in DataLayout

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.
Herald added a reviewer: jdoerfert.


================
Comment at: clang/lib/Basic/Targets/PPC.h:351
       : PPCTargetInfo(Triple, Opts) {
-    resetDataLayout("E-m:e-p:32:32-i64:64-n32");
+    if (Triple.getOS() == llvm::Triple::AIX)
+      resetDataLayout("E-m:a-p:32:32-i64:64-n32");
----------------
`Triple.isOSAIX()` is used by D79719; do we want to be consistent in using that?


================
Comment at: clang/lib/Basic/Targets/PPC.h:400
 
-    if ((Triple.getArch() == llvm::Triple::ppc64le)) {
+    if (Triple.getOS() == llvm::Triple::AIX) {
+      // TODO: Set appropriate ABI for AIX platform.
----------------
`Triple.isOSAIX()` is used by D79719; do we want to be consistent in using that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81270/new/

https://reviews.llvm.org/D81270