[llvm] dc20419 - Rename function to more accurately reflect what it does.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 20 14:41:09 PDT 2020


Author: Eric Christopher
Date: 2020-06-20T14:37:29-07:00
New Revision: dc204193515bb9a00480966fbd6847c774794ae5

URL: https://github.com/llvm/llvm-project/commit/dc204193515bb9a00480966fbd6847c774794ae5
DIFF: https://github.com/llvm/llvm-project/commit/dc204193515bb9a00480966fbd6847c774794ae5.diff

LOG: Rename function to more accurately reflect what it does.

Added: 
    

Modified: 
    llvm/lib/Transforms/Scalar/GVNSink.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/GVNSink.cpp b/llvm/lib/Transforms/Scalar/GVNSink.cpp
index 1e3cc59b48e0..dfb4b7e038ba 100644
--- a/llvm/lib/Transforms/Scalar/GVNSink.cpp
+++ b/llvm/lib/Transforms/Scalar/GVNSink.cpp
@@ -581,7 +581,7 @@ class GVNSink {
 private:
   ValueTable VN;
 
-  bool isInstructionSinkable(Instruction *I) {
+  bool shouldAvoidSinkingInstruction(Instruction *I) {
     // These instructions may change or break semantics if moved.
     if (isa<PHINode>(I) || I->isEHPad() || isa<AllocaInst>(I) ||
         I->getType()->isTokenTy())
@@ -673,7 +673,7 @@ Optional<SinkingInstructionCandidate> GVNSink::analyzeInstructionForSinking(
       NewInsts.push_back(I);
   }
   for (auto *I : NewInsts)
-    if (isInstructionSinkable(I))
+    if (shouldAvoidSinkingInstruction(I))
       return None;
 
   // If we've restricted the incoming blocks, restrict all needed PHIs also


        


More information about the llvm-commits mailing list