[PATCH] D78867: [docs] avoid 'arc land' command

Hubert Tong via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 17:56:07 PDT 2020


hubert.reinterpretcast marked an inline comment as done.
hubert.reinterpretcast added inline comments.


================
Comment at: llvm/docs/Phabricator.rst:206
+* the ``Author`` property of the commit is set to the original author.
+* all phabricator tags except ``Differential Revision`` are stripped
+  from commit message.
----------------
mehdi_amini wrote:
> hubert.reinterpretcast wrote:
> > mehdi_amini wrote:
> > > hubert.reinterpretcast wrote:
> > > > I am against this. I appreciate being able to locate reviewers associated with an area from the commit message.
> > > I think the extra tag is "Reviewed By:"? 
> > Yes; thanks. Also, I find the `Summary` line useful for separating the commit message body from the subject line on the buildbot.
> That seems something to fix on the buildbot side. Git commit message have well known convention that define the title and the description.
I'm fine with that view. Just noting that newer buildbot instances I am aware of still generate the "Comment" with the subject line immediately before the first line of the body.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78867/new/

https://reviews.llvm.org/D78867





More information about the llvm-commits mailing list