[PATCH] D81488: [MSP430] Enable some basic support for debug information

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 10:19:14 PDT 2020


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/test/DebugInfo/MSP430/dwarf-basics.ll:114
+
+attributes #0 = { norecurse nounwind optsize readnone "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "frame-pointer"="none" "less-precise-fpmad"="false" "min-legal-vector-width"="0" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nounwind readnone speculatable willreturn }
----------------
please remove all non-essential attributes (everything in quotes is a good start). They make tests difficult to maintain.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81488/new/

https://reviews.llvm.org/D81488





More information about the llvm-commits mailing list