[PATCH] D81236: Improve LegacyPassManager API to correctly report modified status

[serge via Phabricator via llvm-commits]

serge-sans-paille marked an inline comment as done.
serge-sans-paille added inline comments.


================
Comment at: llvm/include/llvm/Pass.h:216
+  AnalysisType &getAnalysisID(AnalysisID PI, Function &F,
+                              bool *Changed = nullptr);
 };
----------------
mehdi_amini wrote:
> serge-sans-paille wrote:
> > mehdi_amini wrote:
> > > Can you document these added arguments? 
> > > It isn't clear to me what are these about: I wouldn't expect an analysis to change the IR for example.
> > Will do. That's all the salt of this review: an analysis may trigger, as part of its dependencies, a pass that modifies the IR. This modification is currently ignored when computing on-the-fly passes.
> Do you have examples of it? (if so maybe add them to the comment)
Yeah, LoopExtractor depends on BreakCriticalEdges. I'll add that to the comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81236/new/

https://reviews.llvm.org/D81236