[PATCH] D82139: [DWARFYAML][debug_info] Fix array index out of bounds error. NFC.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 19 03:44:21 PDT 2020


jhenderson added reviewers: grimar, MaskRay.
jhenderson added a comment.

Seems reasonable to me.

I assume one of your other changes includes the test coverage for this? Could you remove the failing test case from that change, and add this change as a child, with the removed test case included? That way, your fix has an associated test case from the start. In other words, I'd reorder your dependencies: first D82073 <https://reviews.llvm.org/D82073> (minus failing test) then D82139 <https://reviews.llvm.org/D82139> (with test).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82139/new/

https://reviews.llvm.org/D82139





More information about the llvm-commits mailing list