[PATCH] D81988: [ELF] Refactor ObjFile<ELFT>::initializeSymbols to enforce the invariant: InputFile::symbols has non null entry

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.

LGTM with a nit.



================
Comment at: lld/ELF/InputFiles.cpp:1062
+    uint8_t binding = eSym.getBinding();
+    if (binding != STB_LOCAL) {
+      if (i < firstGlobal)
----------------
You can do:

```
if (eSym.getBinding() != STB_LOCAL) {
```

and inline `STB_LOCAL` value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81988/new/

https://reviews.llvm.org/D81988