[PATCH] D82088: [AVR] Disassemble instructions with fixed Z operand

Dylan McKay via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 18 22:51:54 PDT 2020


dylanmckay accepted this revision.
dylanmckay added a comment.
This revision is now accepted and ready to land.

> Note: I don't know whether the way I've made the Z register printable is the correct way. Maybe the register should be added to the MCInst instead.

The way you've done it looks correct to me - it both prints the operand with the special Z symbol and adds the register to the MCInst, and is consistent with the existing `printOperand` logic. Nice work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82088/new/

https://reviews.llvm.org/D82088





More information about the llvm-commits mailing list