[PATCH] D80801: [DAGCombiner] allow more folding of fadd + fmul into fma

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 18 16:59:15 PDT 2020


efriedma added a comment.

> We are only pulling the trailing addition in with an existing multiply.

The problem here is that it's the "wrong" multiply: you have, essentially `(A*B+D*E)+F`, and you're turning it into `A*B+(D*E+F)`.  I don't think contraction is supposed to cover that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80801/new/

https://reviews.llvm.org/D80801





More information about the llvm-commits mailing list