[PATCH] D81319: [Dexter] Add --source-dir-root flag

[Eric Christopher via llvm-commits]

In this case it looked like both reviewers had said lgtm, but hadn't
actually hit the button :)

On Thu, Jun 18, 2020 at 10:54 AM David Blaikie via Phabricator <
reviews at reviews.llvm.org> wrote:

> dblaikie added a comment.
>
> In D81319#2099642 <https://reviews.llvm.org/D81319#2099642>, @tbosch
> wrote:
>
> > @TWeaver @jmorse It looks like both of you gave an implicit LGTM, is
> that correct?
> >
> > I will wait one more day then submit this change so that it doesn't bit
> rot.
>
>
> (aside: Generally once something's been sent for review it should not be
> committed until approved (otherwise it muddies the waters a bit - it was
> sent for review because the author felt it needed review, but then
> committed without it?))
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D81319/new/
>
> https://reviews.llvm.org/D81319
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200618/a3b9ad0f/attachment.html>