[PATCH] D82055: [DebugInfo] Explicitly permit addr_size = 0x02 when parsing DWARF data

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 18 09:46:05 PDT 2020


probinson added subscribers: debug-info, probinson.
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

LGTM

In a .test file, you don't actually need the comment markers.  They're not harmful either, so up to you whether to leave them in.
Some people prefer that commentary and action lines (REQUIRES, CHECK, etc) have different comment markings, just for readability.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82055/new/

https://reviews.llvm.org/D82055





More information about the llvm-commits mailing list